Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GuSESSenderPolicy available within the @guardian/cdk/lib/constru… #94

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

akash1810
Copy link
Member

What does this change?

Make GuSESSenderPolicy available within the @guardian/cdk/lib/constructs/iam module.

Just makes it easier to interact with.

This was missed in #91.

Does this change require changes to existing projects or CDK CLI?

No.

How to test

n/a

How can we measure success?

Importing goes from:

import { GuSESSenderPolicy } from "@guardian/cdk/lib/constructs/iam/policies/ses";

to:

import { GuSESSenderPolicy } from "@guardian/cdk/lib/constructs/iam

as standard with other constructs in the library.

Have we considered potential risks?

n/a

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Make GuSESSenderPolicy available within the @guardian/cdk/lib/constructs/iam module.

Just makes it easier to interact with.
@akash1810 akash1810 added the needs-new-release Identifying significant changes to the library label Dec 23, 2020
@akash1810 akash1810 requested a review from a team December 23, 2020 14:50
Copy link
Contributor

@jorgeazevedo jorgeazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed!

@akash1810 akash1810 merged commit fc62522 into main Dec 23, 2020
@akash1810 akash1810 deleted the aa-export-ses-policy branch December 23, 2020 14:57
@akash1810 akash1810 mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-new-release Identifying significant changes to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants