chore(deps)!: Update aws-cdk libraries to 1.137.0 #997

akash1810 · 2021-12-22T23:04:33Z

What does this change?

Moving from 1.132.0 to 1.137 brings a few new features and bug fixes, most notably tag support added to AWS::Logs::LogGroup resources!

There are a few snapshot updates to reflect these new features and bug fixes. See the individual commits for more information.

We should update our Lambda constructs to create an explicit LogGroup to take advantage of tag support. See also guardian/cloudwatch-logs-management#19.

BREAKING CHANGE: Update aws-cdk libraries to 1.137.0

How to test

See CI pass.

Note: CI is now witnessing a lot of console.logs, this gets fixed in aws/aws-cdk#18136.

How can we measure success?

Keeping dependencies up to date (and unblocking #995).

Have we considered potential risks?

n/a

Checklist

I have listed any breaking changes, along with a migration path ¹
I have updated the documentation as required for the described changes ²

Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩

akash1810 · 2021-12-22T23:38:16Z

src/constructs/cloudwatch/ec2-alarms.ts

+      metric: props.targetGroup
+        .metricUnhealthyHostCount()
+        .with({ period: Duration.minutes(5), statistic: Statistic.MAXIMUM }),


This resolves a deprecation warning where period and statistic should now be declared against the metric, rather than a top level prop.

akash1810 · 2021-12-22T23:39:24Z

src/constructs/ecs/__snapshots__/ecs-task.test.ts.snap

+  "Mappings": Object {
+    "ServiceprincipalMap": Object {
+      "af-south-1": Object {
+        "states": "states.af-south-1.amazonaws.com",
+      },
+      "ap-east-1": Object {
+        "states": "states.ap-east-1.amazonaws.com",
+      },
+      "ap-northeast-1": Object {
+        "states": "states.ap-northeast-1.amazonaws.com",
+      },
+      "ap-northeast-2": Object {
+        "states": "states.ap-northeast-2.amazonaws.com",
+      },
+      "ap-northeast-3": Object {
+        "states": "states.ap-northeast-3.amazonaws.com",
+      },
+      "ap-south-1": Object {
+        "states": "states.ap-south-1.amazonaws.com",
+      },
+      "ap-southeast-1": Object {
+        "states": "states.ap-southeast-1.amazonaws.com",
+      },
+      "ap-southeast-2": Object {
+        "states": "states.ap-southeast-2.amazonaws.com",
+      },
+      "ap-southeast-3": Object {
+        "states": "states.ap-southeast-3.amazonaws.com",
+      },
+      "ca-central-1": Object {
+        "states": "states.ca-central-1.amazonaws.com",
+      },
+      "cn-north-1": Object {
+        "states": "states.cn-north-1.amazonaws.com",
+      },
+      "cn-northwest-1": Object {
+        "states": "states.cn-northwest-1.amazonaws.com",
+      },
+      "eu-central-1": Object {
+        "states": "states.eu-central-1.amazonaws.com",
+      },
+      "eu-north-1": Object {
+        "states": "states.eu-north-1.amazonaws.com",
+      },
+      "eu-south-1": Object {
+        "states": "states.eu-south-1.amazonaws.com",
+      },
+      "eu-south-2": Object {
+        "states": "states.eu-south-2.amazonaws.com",
+      },
+      "eu-west-1": Object {
+        "states": "states.eu-west-1.amazonaws.com",
+      },
+      "eu-west-2": Object {
+        "states": "states.eu-west-2.amazonaws.com",
+      },
+      "eu-west-3": Object {
+        "states": "states.eu-west-3.amazonaws.com",
+      },
+      "me-south-1": Object {
+        "states": "states.me-south-1.amazonaws.com",
+      },
+      "sa-east-1": Object {
+        "states": "states.sa-east-1.amazonaws.com",
+      },
+      "us-east-1": Object {
+        "states": "states.us-east-1.amazonaws.com",
+      },
+      "us-east-2": Object {
+        "states": "states.us-east-2.amazonaws.com",
+      },
+      "us-gov-east-1": Object {
+        "states": "states.us-gov-east-1.amazonaws.com",
+      },
+      "us-gov-west-1": Object {
+        "states": "states.us-gov-west-1.amazonaws.com",
+      },
+      "us-iso-east-1": Object {
+        "states": "states.amazonaws.com",
+      },
+      "us-iso-west-1": Object {
+        "states": "states.amazonaws.com",
+      },
+      "us-isob-east-1": Object {
+        "states": "states.amazonaws.com",
+      },
+      "us-west-1": Object {
+        "states": "states.us-west-1.amazonaws.com",
+      },
+      "us-west-2": Object {
+        "states": "states.us-west-2.amazonaws.com",
+      },
+    },
+  },


From aws/aws-cdk#17984.

akash1810 · 2021-12-22T23:40:26Z

src/constructs/ecs/__snapshots__/ecs-task.test.ts.snap

+        "Tags": Array [
+          Object {
+            "Key": "App",
+            "Value": "ecs-test",
+          },
+          Object {
+            "Key": "gu:cdk:version",
+            "Value": "TEST",
+          },
+          Object {
+            "Key": "gu:repo",
+            "Value": "guardian/cdk",
+          },
+          Object {
+            "Key": "Stack",
+            "Value": "test-stack",
+          },
+          Object {
+            "Key": "Stage",
+            "Value": Object {
+              "Ref": "Stage",
+            },
+          },
+        ],


CloudWatch Logs support tags now! 🎉

akash1810 · 2021-12-22T23:40:53Z

src/constructs/loadbalancing/elb.test.ts

@@ -164,7 +164,7 @@ describe("The GuHttpsClassicLoadBalancer class", () => {
      ...app,
      vpc,
      listener: {
-        sslCertificateId: "certificateId",
+        sslCertificateArn: "certificateId",


sslCertificateId is deprecated in favour of sslCertificateArn.

akash1810 · 2021-12-22T23:41:22Z

src/patterns/__snapshots__/api-lambda.test.ts.snap

+      "DependsOn": Array [
+        "lambdaapi2AccountFAF30ECB",
+      ],


From aws/aws-cdk#18011.

akash1810 · 2021-12-22T23:41:47Z

src/patterns/__snapshots__/kinesis-lambda.test.ts.snap

+                "kinesis:DescribeStream",
+                "kinesis:ListStreams",


From aws/aws-cdk#17358.

This version follows v49.0.0 of the CloudFormation Resource specification, which sees tag support added to `AWS::Logs::LogGroup` resources. It also includes a fix for Kinesis triggered Lambdas, specifically fixing the permissions needed by the Lambda on the Kinesis stream. See: - https://github.com/aws/aws-cdk/releases/tag/v1.133.0 - https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/cfnspec/CHANGELOG.md#cloudformation-resource-specification-v4900 - aws/aws-cdk#17358 BREAKING CHANGE: Update aws-cdk libraries to 1.133.0

BREAKING CHANGE: Update aws-cdk libraries to 1.134.0

BREAKING CHANGE: Update aws-cdk libraries to 1.135.0

This version follows v49.0.0 of the CloudFormation Resource specification, which sees `ShardCount` on `AWS::Kinesis::Stream` to be optional (required = false). This manifests in the properties in the snapshot being alphabetised, i.e. this is a a no-op for a `GuKinesisStream`. See: - https://github.com/aws/aws-cdk/releases/tag/v1.136.0 - https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/cfnspec/CHANGELOG.md#cloudformation-resource-specification-v5100 BREAKING CHANGE: Update aws-cdk libraries to 1.136.0

This brings in two fixes which is reflected in the snapshot changes. See: - aws/aws-cdk#17984 - aws/aws-cdk#18011 BREAKING CHANGE: Update aws-cdk libraries to 1.137.0

github-actions · 2021-12-23T11:15:54Z

🎉 This PR is included in version 32.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

akash1810 requested a review from a team December 22, 2021 23:04

akash1810 commented Dec 22, 2021

View reviewed changes

akash1810 mentioned this pull request Dec 23, 2021

ci: Move AWS CDK check into it's own GHA job #998

Merged

2 tasks

jacobwinch approved these changes Dec 23, 2021

View reviewed changes

akash1810 added 7 commits December 23, 2021 11:07

chore(deps)!: Update aws-cdk libraries to 1.134.0

cc27a72

BREAKING CHANGE: Update aws-cdk libraries to 1.134.0

chore(deps)!: Update aws-cdk libraries to 1.135.0

afd4a37

BREAKING CHANGE: Update aws-cdk libraries to 1.135.0

chore(deps)!: Update aws-cdk libraries to 1.137.0

f8d72e3

This brings in two fixes which is reflected in the snapshot changes. See: - aws/aws-cdk#17984 - aws/aws-cdk#18011 BREAKING CHANGE: Update aws-cdk libraries to 1.137.0

ci: Align aws-cdk version in integration-test

903ce55

chore: Resolve deprecation warnings

9c09d20

akash1810 force-pushed the aa-bump branch from 1d5fd0e to 9c09d20 Compare December 23, 2021 11:07

akash1810 enabled auto-merge December 23, 2021 11:08

akash1810 merged commit 4358c6a into main Dec 23, 2021

akash1810 deleted the aa-bump branch December 23, 2021 11:11

github-actions bot added the released label Dec 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps)!: Update aws-cdk libraries to 1.137.0 #997

chore(deps)!: Update aws-cdk libraries to 1.137.0 #997

akash1810 commented Dec 22, 2021 •

edited

Loading

akash1810 Dec 22, 2021

akash1810 Dec 22, 2021

akash1810 Dec 22, 2021

akash1810 Dec 22, 2021

akash1810 Dec 22, 2021

akash1810 Dec 22, 2021

github-actions bot commented Dec 23, 2021

chore(deps)!: Update aws-cdk libraries to 1.137.0 #997

chore(deps)!: Update aws-cdk libraries to 1.137.0 #997

Conversation

akash1810 commented Dec 22, 2021 • edited Loading

What does this change?

How to test

How can we measure success?

Have we considered potential risks?

Checklist

Footnotes

akash1810 Dec 22, 2021

Choose a reason for hiding this comment

akash1810 Dec 22, 2021

Choose a reason for hiding this comment

akash1810 Dec 22, 2021

Choose a reason for hiding this comment

akash1810 Dec 22, 2021

Choose a reason for hiding this comment

akash1810 Dec 22, 2021

Choose a reason for hiding this comment

akash1810 Dec 22, 2021

Choose a reason for hiding this comment

github-actions bot commented Dec 23, 2021

akash1810 commented Dec 22, 2021 •

edited

Loading