Add slot targeting to indicate teads eligibility #1603
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0c49a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
deedeeh
approved these changes
Sep 30, 2024
arelra
reviewed
Sep 30, 2024
| ]; | ||
|
|
||
| const isEligibleForTeads = (slotId: string) => { | ||
| const { page } = window.guardian.config; |
There was a problem hiding this comment.
Minor:
Suggested change
| const { page } = window.guardian.config; | |
| const { contentType, pageId, isSensitive } = window.guardian.config.page; |
arelra
reviewed
Sep 30, 2024
Comment on lines
140
to
142
| const instancesOfBannedKeywords = urlKeywords.filter((keyword) => | ||
| bannedUrlKeywords.includes(keyword), | ||
| ); |
There was a problem hiding this comment.
Minor:
Suggested change
| const instancesOfBannedKeywords = urlKeywords.filter((keyword) => | |
| bannedUrlKeywords.includes(keyword), | |
| ); | |
| const hasBannedKeywords: boolean = urlKeywords.some((keyword) => | |
| bannedUrlKeywords.includes(keyword), | |
| ); |
There was a problem hiding this comment.
Hadn't seen this before - definitely neater, thanks!
arelra
reviewed
Sep 30, 2024
src/define/Advert.ts
Outdated
Comment on lines
145
to
149
| if (isEligibleForTeads(adSlotNode.id)) { | ||
| slotTargeting['teadsEligible'] = 'true'; | ||
| } else { | ||
| slotTargeting['teadsEligible'] = 'false'; | ||
| } |
There was a problem hiding this comment.
Most other slot targeting is set in defineSlot might that be a better place to set this also?
arelra
reviewed
Sep 30, 2024
| @@ -0,0 +1,83 @@ | |||
| import { isEligibleForTeads } from './teads-eligibility'; | |||
|
|
|||
| describe('Teads Eligibility', () => { | |||
arelra
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds slot level targeting to add a key word to indicate if a slot is eligible for teads or not. The checks in this diagram have been implemented as code checks to reduce the logic we need to add in GAM.
Why?
At the moment a lot of targeting needs to be added in GAM to determine slots which are eligible for teads. It's complex to set up ads in GAM so that they don't target slots which are eligible for teads. By adding a specific key word we can simplify the targeting set up for teads in GAM.