Use eslint for linting typescript #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request switches over from
tslinttoeslintfor typescript. We're doing this as the Tyepscript roadmap for 2019 microsoft/TypeScript#29288 recommended transitioning to ESLint. the TypeScript team explain thateslinthas a more performant architecture thantslintand that they will only be focusing oneslintwhen providing editor linting integration for TypeScript. As a resulttslintis being deprecated.I've also updated our
yarn lintrule toyarn validateas I've inserted the commandtsc --noEmitwhich errors on Typescript errors, something lint'ing doesn't do.