Rework container level spacing for beta containers #12951
Merged
+190
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -54 B (-0.01%) Total Size: 945 kB ℹ️ View Unchanged
|
abeddow91
commented
Dec 5, 2024
abeddow91
force-pushed
the
ab/spacing-logic
branch
from
8f79575 to
2089b7f
Compare
abeddow91
force-pushed
the
ab/spacing-logic
branch
from
2089b7f to
4c60c24
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
changed the title
cemms1
approved these changes
Dec 11, 2024
Comment on lines
+58
to
+59
| /** Fronts containers spacing rules vary depending on the size of their container spacing which is derived from if the next container is a primary or secondary. */ | ||
| containerSpacing?: 'large' | 'small'; |
Comment on lines
+45
to
+50
| /** Depending on the next sibling of the container, we assign either large or small spacing rules during render */ | ||
| const getContainerSpacing = (nextSiblingCollection?: FECollectionType) => { | ||
| const nextCollectionIsPrimary = | ||
| nextSiblingCollection?.config.collectionLevel === 'Primary'; | ||
| return nextCollectionIsPrimary ? 'large' : 'small'; | ||
| }; |
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @abeddow91 9 minutes and 57 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Reworks how container spacing is calculated and adds it to the model so that beta containers have either 24px or 40px bottom padding.
This is calculated at the enhancer layer by checking if the next sibling container has
primarycontainer styling. If this is true, we assign "large" container spacing, else we assign "small" container spacing.There is no extra padding adding after thrashers or ads. These continue to sit flush with the top of the container that follows them.
Previously, container spacing was handled in a mixture of places. This PR reconciles this soft contract so that bottom container spacing is only set in one place: in the front section.
Why?
We want to add additional spacing to the bottom of beta containers that are followed by container with primary styling. It doesn't matter what styling the current container has.
Container spacing rules
small === is not followed by a primary container === 24px bottom padding
large === is followed by a primary container === 40px bottom padding
Screenshots