Handle subtitles asset type #14533
Open
Handle subtitles asset type #14533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnm-notona
reviewed
Sep 26, 2025
gnm-notona
approved these changes
Sep 26, 2025
Fweddi
force-pushed
the
fp/handle-subtitles-asset-type
branch
from
312404f to
6dc6aeb
Compare
Fweddi
added a commit
to guardian/scrooge-extras
that referenced
this pull request
Oct 1, 2025
Scrooge 22.2.0 brought in a breaking change where reserved keywords in Thrift were strictly enforced (https://twitter.github.io/scrooge/changelog.html#id13) This causes issues downstream in content-api-models which uses the reserved keyword 'end' (https://github.com/guardian/content-api-models/blob/main/models/src/main/thrift/content/v1.thrift#L399-L400). The long-term solution is to rename the 'end' field to 'endDate' (see guardian/content-api#2903), but in the short term we need to unblock the release of the apps-rendering-api-models library, which is currently failing. Releasing this library will allow us to support the new Subtitles asset type in DCR (guardian/dotcom-rendering#14533).
Fweddi
added a commit
to guardian/scrooge-extras
that referenced
this pull request
Oct 1, 2025
Scrooge 22.2.0 brought in a breaking change where reserved keywords in Thrift were strictly enforced (https://twitter.github.io/scrooge/changelog.html#id13) This causes issues downstream in content-api-models which uses the reserved keyword 'end' (https://github.com/guardian/content-api-models/blob/main/models/src/main/thrift/content/v1.thrift#L399-L400). The long-term solution is to rename the 'end' field to 'endDate' (see guardian/content-api#2903), but in the short term we need to unblock the release of the apps-rendering-api-models library, which is currently failing. Releasing this library will allow us to support the new Subtitles asset type in DCR (guardian/dotcom-rendering#14533).
Fweddi
added a commit
to guardian/scrooge-extras
that referenced
this pull request
Oct 1, 2025
Scrooge 22.2.0 brought in a breaking change where reserved keywords in Thrift were strictly enforced (https://twitter.github.io/scrooge/changelog.html#id13) This causes issues downstream in content-api-models which uses the reserved keyword 'end' (https://github.com/guardian/content-api-models/blob/main/models/src/main/thrift/content/v1.thrift#L399-L400). The long-term solution is to rename the 'end' field to 'endDate' (see guardian/content-api#2903), but in the short term we need to unblock the release of the apps-rendering-api-models library, which is currently failing. Releasing this library will allow us to support the new Subtitles asset type in DCR (guardian/dotcom-rendering#14533).
Fweddi
added a commit
to guardian/scrooge-extras
that referenced
this pull request
Oct 2, 2025
Scrooge 22.2.0 brought in a breaking change where reserved keywords in Thrift were strictly enforced (https://twitter.github.io/scrooge/changelog.html#id13) This causes issues downstream in content-api-models which uses the reserved keyword 'end' (https://github.com/guardian/content-api-models/blob/main/models/src/main/thrift/content/v1.thrift#L399-L400). The long-term solution is to rename the 'end' field to 'endDate' (see guardian/content-api#2903), but in the short term we need to unblock the release of the apps-rendering-api-models library, which is currently failing. Releasing this library will allow us to support the new Subtitles asset type in DCR (guardian/dotcom-rendering#14533).
Fweddi
added
run_chromatic
Fweddi
added
run_chromatic
Fweddi
force-pushed
the
fp/handle-subtitles-asset-type
branch
from
7c01f3b to
a026504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Why are you doing this?
We are adding a new subtitles asset type to media atoms (guardian/content-atom#178). Currently parts of DCR assume the asset type of media atoms to be video.
We need to explicitly filter out subtitles assets, so we don't accidentally try to pass a subtitles asset to a video player (as if it were a video).
Notes
It's possible we haven't been exhaustive with all the cases where we need to add a filter. We will need to be on the look out for such cases in future.