-
Notifications
You must be signed in to change notification settings - Fork 30
Move branding outside of standard footer for labs cards in new containers #14600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1d8f24
to
ce963db
Compare
ce963db
to
3cf079f
Compare
… for the labs redesign
…dContentLabel based on viewport size
3cf079f
to
3bb78f7
Compare
on-ye
reviewed
Oct 3, 2025
on-ye
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When the labs redesign switch is on:
SponsoredContentLabel
component for the brandingSponsoredContentLabel
logo to 60px to ensure alignment across cards in case one logo is smaller than othersSponsoredContentLabel
in the Card component for tablet viewport size only and horizontal in all other cases. Duplicates the component and uses CSS to control the behaviour to avoid unnecessary JS usageWhy?
Part of the Labs redesign work
The redesigned labs cards have the branding right at the bottom of the card on fronts
Screenshots