Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update node to 18.16.0 #7948

Merged
merged 5 commits into from
Jun 20, 2023
Merged

update node to 18.16.0 #7948

merged 5 commits into from
Jun 20, 2023

Conversation

georgeblahblah
Copy link
Contributor

@georgeblahblah georgeblahblah commented Jun 16, 2023 •
edited
Loading

What does this change?

Closes #7577

Why?

Node 16 End of Life is approaching in September. I think now is a good time to move to Node 18.

How to test?

@georgeblahblah georgeblahblah changed the title update node to 18.12.0 update node to 18.16.0 Jun 16, 2023
@github-actions
Copy link

github-actions bot commented Jun 16, 2023 •
edited
Loading

Size Change: -147 B (0%)

Total Size: 532 kB

Filename Size Change
dotcom-rendering/dist/index.modern.********************.js 33.1 kB -147 B (0%)
ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1813.modern.********************.js 6.52 kB 0 B
dotcom-rendering/dist/2006.modern.********************.js 3.84 kB 0 B
dotcom-rendering/dist/2136.modern.********************.js 3.11 kB 0 B
dotcom-rendering/dist/2216.modern.********************.js 3.07 kB 0 B
dotcom-rendering/dist/2626.modern.********************.js 3.55 kB 0 B
dotcom-rendering/dist/2854.modern.********************.js 3.3 kB 0 B
dotcom-rendering/dist/3398.modern.********************.js 20 kB 0 B
dotcom-rendering/dist/3577.modern.********************.js 4.33 kB 0 B
dotcom-rendering/dist/3993.modern.********************.js 6.21 kB 0 B
dotcom-rendering/dist/5153.modern.********************.js 2.28 kB 0 B
dotcom-rendering/dist/516.modern.********************.js 17.3 kB 0 B
dotcom-rendering/dist/5384.modern.********************.js 3.04 kB 0 B
dotcom-rendering/dist/5474.modern.********************.js 2.53 kB 0 B
dotcom-rendering/dist/6130.modern.********************.js 2.95 kB 0 B
dotcom-rendering/dist/6297.modern.********************.js 21.3 kB 0 B
dotcom-rendering/dist/6345.modern.********************.js 4.71 kB 0 B
dotcom-rendering/dist/6633.modern.********************.js 3.22 kB 0 B
dotcom-rendering/dist/6814.modern.********************.js 5.41 kB 0 B
dotcom-rendering/dist/6939.modern.********************.js 5.35 kB 0 B
dotcom-rendering/dist/7184.modern.********************.js 10.7 kB 0 B
dotcom-rendering/dist/7392.modern.********************.js 2.49 kB 0 B
dotcom-rendering/dist/7872.modern.********************.js 1.89 kB 0 B
dotcom-rendering/dist/8326.modern.********************.js 2.55 kB 0 B
dotcom-rendering/dist/8452.modern.********************.js 4.28 kB 0 B
dotcom-rendering/dist/8888.modern.********************.js 2.75 kB +1 B (0%)
dotcom-rendering/dist/9704.modern.********************.js 2.59 kB 0 B
dotcom-rendering/dist/9861.modern.********************.js 3.5 kB 0 B
dotcom-rendering/dist/9874.modern.********************.js 4.71 kB 0 B
dotcom-rendering/dist/9977.modern.********************.js 3.81 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 410 B 0 B
dotcom-rendering/dist/AnimatePulsingDots-importable.modern.********************.js 389 B 0 B
dotcom-rendering/dist/atomIframe.modern.********************.js 516 B 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 463 B 0 B
dotcom-rendering/dist/Branding-importable.modern.********************.js 2.18 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 5.03 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.modern.********************.js 6.46 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 6.59 kB 0 B
dotcom-rendering/dist/Carousel-importable.modern.********************.js 5.27 kB 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 474 B 0 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.77 kB 0 B
dotcom-rendering/dist/discussion.modern.********************.js 393 B 0 B
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 4.08 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 3.35 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 2.72 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.25 kB 0 B
dotcom-rendering/dist/embedIframe.modern.********************.js 520 B 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 1.93 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 2.97 kB -1 B (0%)
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 1.89 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 3.41 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 511 B 0 B
dotcom-rendering/dist/frameworks.modern.********************.js 20.5 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 3.36 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 11.4 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 6.32 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.42 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 13.3 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 10.3 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 476 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 13.6 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 2.79 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 5.8 kB -1 B (0%)
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 4.09 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.modern.********************.js 3.82 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 3.44 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 481 B 0 B
dotcom-rendering/dist/LatestLinks-importable.modern.********************.js 1.5 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 4.9 kB -1 B (0%)
dotcom-rendering/dist/Liveness-importable.modern.********************.js 5.52 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.modern.********************.js 5.59 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.32 kB 0 B
dotcom-rendering/dist/Metrics-importable.modern.********************.js 2.46 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 5.19 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.37 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 3.76 kB 0 B
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 621 B 0 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 3.77 kB -2 B (0%)
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 483 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 478 B 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 475 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 460 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 2.7 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 5.4 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 3.23 kB 0 B
dotcom-rendering/dist/relativeTime.modern.********************.js 976 B 0 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.05 kB +2 B (0%)
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 2.54 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.modern.********************.js 4.37 kB 0 B
dotcom-rendering/dist/sentry.modern.********************.js 766 B 0 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 3.88 kB 0 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 2.91 kB 0 B
dotcom-rendering/dist/shimport.modern.********************.js 2.78 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 719 B 0 B
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 5.03 kB 0 B
dotcom-rendering/dist/SignInGateMain.modern.********************.js 2.93 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.modern.********************.js 3.84 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 3.45 kB +2 B (0%)
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 2.82 kB 0 B
dotcom-rendering/dist/Snow-importable.modern.********************.js 4.26 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.17 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 3.94 kB 0 B
dotcom-rendering/dist/SubNav-importable.modern.********************.js 2.85 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.43 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.modern.********************.js 3.08 kB 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 476 B 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.modern.********************.js 631 B 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 1 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 2.8 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.33 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 2.64 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 4.05 kB 0 B

compressed-size-action

@georgeblahblah georgeblahblah marked this pull request as ready for review June 16, 2023 12:27
@georgeblahblah georgeblahblah requested a review from a team as a code owner June 16, 2023 12:27
@georgeblahblah georgeblahblah added the run_chromatic Runs chromatic when label is applied label Jun 16, 2023
@AshCorr
Copy link
Member

AshCorr commented Jun 16, 2023

Don't forget to bump the version in https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/Containerfile too!

@georgeblahblah
Copy link
Contributor Author

georgeblahblah commented Jun 16, 2023 •
edited
Loading

Don't forget to bump the version in https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/Containerfile too!

@AshCorr definitely would have forgotten!! Thanks

@JamieB-gu
Copy link
Contributor

Don't forget to bump the version in https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/Containerfile too!

@AshCorr is there any way we could derive this either from the .nvmrc or derive both from the same place?

AshCorr
AshCorr approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@AshCorr AshCorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AshCorr
Copy link
Member

AshCorr commented Jun 16, 2023

@AshCorr is there any way we could derive this either from the .nvmrc or derive both from the same place?

Yea, you could probably have a step just before the action that builds an image which does a Search & Relace to replace a placeholder version string in the Containerfile with the version in the .nvmrc

@mxdvl mxdvl mentioned this pull request Jun 16, 2023
Closed
@georgeblahblah georgeblahblah merged commit fb30970 into main Jun 20, 2023
@georgeblahblah georgeblahblah deleted the gb/node-18 branch June 20, 2023 09:29
@mxdvl mxdvl mentioned this pull request Jun 21, 2023
Merged
@JamieB-gu JamieB-gu mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshCorr AshCorr AshCorr approved these changes

Assignees
No one assigned
Labels
apps-rendering dotcom-rendering run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 18 upgrade for DCR & AR
3 participants
@georgeblahblah @AshCorr @JamieB-gu