Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 18.17.0 #8337

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Node 18.17.0 #8337

merged 6 commits into from
Jul 24, 2023

Conversation

georgeblahblah
Copy link
Contributor

@georgeblahblah georgeblahblah commented Jul 21, 2023 •
edited
Loading

What does this change?

Why?

  • Keeping things up to date

@georgeblahblah georgeblahblah requested a review from a team as a code owner July 21, 2023 10:03
@georgeblahblah georgeblahblah added run_chromatic Runs chromatic when label is applied and removed apps-rendering dotcom-rendering labels Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 635 kB

ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1244.modern.********************.js 869 B
dotcom-rendering/dist/1294.modern.********************.js 5.36 kB
dotcom-rendering/dist/1321.modern.********************.js 2.29 kB
dotcom-rendering/dist/1335.modern.********************.js 3.96 kB
dotcom-rendering/dist/1355.modern.********************.js 3.7 kB
dotcom-rendering/dist/1465.modern.********************.js 3.31 kB
dotcom-rendering/dist/1486.modern.********************.js 745 B
dotcom-rendering/dist/1848.modern.********************.js 644 B
dotcom-rendering/dist/187.modern.********************.js 3.22 kB
dotcom-rendering/dist/1948.modern.********************.js 1.88 kB
dotcom-rendering/dist/1987.modern.********************.js 3.51 kB
dotcom-rendering/dist/1997.modern.********************.js 745 B
dotcom-rendering/dist/2071.modern.********************.js 745 B
dotcom-rendering/dist/2087.modern.********************.js 3.56 kB
dotcom-rendering/dist/21.modern.********************.js 758 B
dotcom-rendering/dist/2126.modern.********************.js 885 B
dotcom-rendering/dist/2201.modern.********************.js 778 B
dotcom-rendering/dist/2228.modern.********************.js 901 B
dotcom-rendering/dist/2339.modern.********************.js 779 B
dotcom-rendering/dist/2494.modern.********************.js 779 B
dotcom-rendering/dist/275.modern.********************.js 697 B
dotcom-rendering/dist/3024.modern.********************.js 621 B
dotcom-rendering/dist/3146.modern.********************.js 6.52 kB
dotcom-rendering/dist/3239.modern.********************.js 4.89 kB
dotcom-rendering/dist/3314.modern.********************.js 6.21 kB
dotcom-rendering/dist/3358.modern.********************.js 638 B
dotcom-rendering/dist/3549.modern.********************.js 21.3 kB
dotcom-rendering/dist/356.modern.********************.js 827 B
dotcom-rendering/dist/3569.modern.********************.js 2.49 kB
dotcom-rendering/dist/3960.modern.********************.js 619 B
dotcom-rendering/dist/4113.modern.********************.js 757 B
dotcom-rendering/dist/4424.modern.********************.js 3.64 kB
dotcom-rendering/dist/4593.modern.********************.js 1.67 kB
dotcom-rendering/dist/4734.modern.********************.js 760 B
dotcom-rendering/dist/4811.modern.********************.js 2.54 kB
dotcom-rendering/dist/5021.modern.********************.js 963 B
dotcom-rendering/dist/5071.modern.********************.js 941 B
dotcom-rendering/dist/5141.modern.********************.js 3.91 kB
dotcom-rendering/dist/5210.modern.********************.js 632 B
dotcom-rendering/dist/5251.modern.********************.js 5.28 kB
dotcom-rendering/dist/533.modern.********************.js 11.9 kB
dotcom-rendering/dist/5474.modern.********************.js 620 B
dotcom-rendering/dist/5707.modern.********************.js 2.23 kB
dotcom-rendering/dist/5974.modern.********************.js 744 B
dotcom-rendering/dist/6118.modern.********************.js 681 B
dotcom-rendering/dist/640.modern.********************.js 710 B
dotcom-rendering/dist/6437.modern.********************.js 867 B
dotcom-rendering/dist/6534.modern.********************.js 573 B
dotcom-rendering/dist/6541.modern.********************.js 812 B
dotcom-rendering/dist/6840.modern.********************.js 4.71 kB
dotcom-rendering/dist/7039.modern.********************.js 25.8 kB
dotcom-rendering/dist/7074.modern.********************.js 19 kB
dotcom-rendering/dist/7133.modern.********************.js 698 B
dotcom-rendering/dist/7305.modern.********************.js 886 B
dotcom-rendering/dist/7401.modern.********************.js 689 B
dotcom-rendering/dist/7569.modern.********************.js 4.55 kB
dotcom-rendering/dist/7688.modern.********************.js 815 B
dotcom-rendering/dist/786.modern.********************.js 477 B
dotcom-rendering/dist/8112.modern.********************.js 3.35 kB
dotcom-rendering/dist/8165.modern.********************.js 927 B
dotcom-rendering/dist/8170.modern.********************.js 491 B
dotcom-rendering/dist/8217.modern.********************.js 4.59 kB
dotcom-rendering/dist/8268.modern.********************.js 5.5 kB
dotcom-rendering/dist/836.modern.********************.js 5.2 kB
dotcom-rendering/dist/8447.modern.********************.js 963 B
dotcom-rendering/dist/8505.modern.********************.js 556 B
dotcom-rendering/dist/8555.modern.********************.js 688 B
dotcom-rendering/dist/8622.modern.********************.js 859 B
dotcom-rendering/dist/8638.modern.********************.js 834 B
dotcom-rendering/dist/8834.modern.********************.js 3.53 kB
dotcom-rendering/dist/9490.modern.********************.js 829 B
dotcom-rendering/dist/9812.modern.********************.js 2.75 kB
dotcom-rendering/dist/9906.modern.********************.js 6.27 kB
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 411 B
dotcom-rendering/dist/AnimatePulsingDots-importable.modern.********************.js 387 B
dotcom-rendering/dist/atomIframe.modern.********************.js 516 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 3.35 kB
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.modern.********************.js 4.05 kB
dotcom-rendering/dist/Branding-importable.modern.********************.js 2.19 kB
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 5.44 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.modern.********************.js 6.47 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 6.6 kB
dotcom-rendering/dist/Carousel-importable.modern.********************.js 6.25 kB
dotcom-rendering/dist/CarouselForNewsletters-importable.modern.********************.js 6.28 kB
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 474 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.79 kB
dotcom-rendering/dist/discussion.modern.********************.js 394 B
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 24 kB
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 3.8 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 2.71 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.25 kB
dotcom-rendering/dist/embedIframe.modern.********************.js 518 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 1.95 kB
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 2.98 kB
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 1.97 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 3.42 kB
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 510 B
dotcom-rendering/dist/frameworks.modern.********************.js 20.8 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 3.36 kB
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 11.4 kB
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 6.35 kB
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.42 kB
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 14 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 10.3 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 476 B
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 10.8 kB
dotcom-rendering/dist/index.modern.********************.js 32.6 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 2.78 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 5.8 kB
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 4.08 kB
dotcom-rendering/dist/InteractiveSupportButton-importable.modern.********************.js 4.18 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 3.04 kB
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 482 B
dotcom-rendering/dist/LatestLinks-importable.modern.********************.js 4.41 kB
dotcom-rendering/dist/LightboxHash-importable.modern.********************.js 514 B
dotcom-rendering/dist/LightboxJavascript-importable.modern.********************.js 4.34 kB
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 5.13 kB
dotcom-rendering/dist/Liveness-importable.modern.********************.js 5.53 kB
dotcom-rendering/dist/ManyNewsletterSignUp-importable.modern.********************.js 4.92 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.31 kB
dotcom-rendering/dist/Metrics-importable.modern.********************.js 2.32 kB
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 5.36 kB
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.57 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 3.8 kB
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 621 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 3.54 kB
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 482 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 479 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 476 B
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 460 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 3.06 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 5.81 kB
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 3.26 kB
dotcom-rendering/dist/relativeTime.modern.********************.js 979 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.87 kB
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 2.57 kB
dotcom-rendering/dist/SendAMessage-importable.modern.********************.js 4.37 kB
dotcom-rendering/dist/sentry.modern.********************.js 766 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 3.75 kB
dotcom-rendering/dist/SetAdTargeting-importable.modern.********************.js 535 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 2.92 kB
dotcom-rendering/dist/shimport.modern.********************.js 2.79 kB
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 720 B
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 5.46 kB
dotcom-rendering/dist/SignInGateMain.modern.********************.js 2.96 kB
dotcom-rendering/dist/SignInGateMainCheckoutComplete.modern.********************.js 3.87 kB
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 3.67 kB
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 2.92 kB
dotcom-rendering/dist/Snow-importable.modern.********************.js 4.22 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.16 kB
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 3.99 kB
dotcom-rendering/dist/SubNav-importable.modern.********************.js 2.33 kB
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.92 kB
dotcom-rendering/dist/TableOfContents-importable.modern.********************.js 3.08 kB
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 477 B
dotcom-rendering/dist/TopRightAdSlot-importable.modern.********************.js 634 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 1.01 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 2.79 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.33 kB
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 2.65 kB
dotcom-rendering/dist/WeatherData-importable.modern.********************.js 4.88 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 953 B

compressed-size-action

@georgeblahblah georgeblahblah marked this pull request as draft July 21, 2023 12:36
@georgeblahblah georgeblahblah marked this pull request as ready for review July 21, 2023 16:23
@mxdvl
Copy link
Contributor

mxdvl commented Jul 24, 2023 •
edited
Loading

Nice!

Was #7998 helpful?
Did you know that @types/* package need to have a matching major and minor version to the corresponding library? It seems like the actual new features are unused in our project, so it's not a major issue.

@georgeblahblah
Copy link
Contributor Author

georgeblahblah commented Jul 24, 2023 •
edited by mxdvl
Loading

Was #7998 helpful?

yes very -- I'd forgotten about Containerfile and the AMIgo images!!

Did you know that @types/* package need to have a matching major and minor version to the corresponding library

I had a feeling that was the case, although I also remember something about a dependency which doesn't follow this pattern, but I can't remember which one. I'll update this PR to use @types/node@18.17.0 which is now available.

@mxdvl
Copy link
Contributor

mxdvl commented Jul 24, 2023

Did you know that @types/* package need to have a matching major and minor version to the corresponding library

I had a feeling that was the case, although I also remember something about a dependency which doesn't follow this pattern, but I can't remember which one. I'll update this PR to use @types/node@18.17.0 which is now available.

This is the contract from DefinitelyTyped, but the community has an inherent lag to the main library authors. There is no defined contract for packages that are below version 1.0.0, where minor versions are allowed to produce breaking changes.

For popular packages, it can be quite quick, e.g. types for Node 18.17 were released two days ago, but at times I’ve had to raise PRs to update the type definitions myself! As they mention in the doc:

It's common for type declaration package updates to lag behind library updates because it's often library users, not maintainers, who update Definitely Typed when new library features are released. So there may be a lag of days, weeks, or even months before a helpful community member sends a PR to update the type declaration package for a new library release. If you're impacted by this, you can be the change you want to see in the world and you can be that helpful community member!

@georgeblahblah georgeblahblah merged commit 34edeea into main Jul 24, 2023
@georgeblahblah georgeblahblah deleted the gb/node-18-17-0 branch July 24, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxdvl mxdvl mxdvl approved these changes

Assignees
No one assigned
Labels
apps-rendering dotcom-rendering run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgeblahblah @mxdvl