Improve naming in the AR build #8904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannakok
changed the title
ioannakok
changed the title
|
Size Change: 0 B 🆕 Total Size: 0 B |
alinaboghiu
reviewed
Sep 25, 2023
.github/workflows/ar-ci.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| name: "AR CI" | |||
| name: AR Build | |||
There was a problem hiding this comment.
Not super clear from the PR sorry, why are we renaming this job?
And would we also want to rename the file?
There was a problem hiding this comment.
I mainly wanted to give a name to the job because I noticed in the GH UI in the required checks it's called just "build"
I will keep it as "AR CI" and give the same name to the job as it builds and uploads artifacts to Riff-Raff. CI is more accurate.
abeddow91
approved these changes
Sep 25, 2023
This will give the job a more descriptive name in the GH UI instead of the current "build".
ioannakok
force-pushed
the
rename-ar-build
branch
from
e4dd81d
to
e26c558
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Give "AR CI" name to the AR build job.
Why?
Without a name it is currently called "build" in the required checks UI which is not very descriptive. Will become "AR CI".
Renaming steps