Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Section Fronts AB test #9114

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Remove Section Fronts AB test #9114

merged 3 commits into from
Oct 12, 2023

Conversation

domlander
Copy link
Contributor

@domlander domlander commented Oct 12, 2023 •
edited
Loading

What does this change?

  • Remove Section Fronts AB test.
  • Retains the section front page-collection key value pairs for testing, as the ads team would still like to be able to test campaigns. Therefore, the network fronts server-side AB test has not been removed and the targeted collections for section fronts has been combined with the targeted collections for the network front. This AB test will be removed once campaign testing is complete.

Why?

The test has ended.

@domlander domlander requested a review from a team as a code owner October 12, 2023 07:46
@domlander domlander force-pushed the doml/remove-section-fronts-ab-test branch from 923d5ed to 634864b Compare October 12, 2023 07:47
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@domlander domlander added the run_chromatic Runs chromatic when label is applied label Oct 12, 2023
@domlander domlander mentioned this pull request Oct 12, 2023
Merged
chrislomaxjones
chrislomaxjones approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@chrislomaxjones chrislomaxjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@domlander domlander merged commit cebb395 into main Oct 12, 2023
22 checks passed
@domlander domlander deleted the doml/remove-section-fronts-ab-test branch October 12, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislomaxjones chrislomaxjones chrislomaxjones approved these changes

Assignees
No one assigned
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domlander @chrislomaxjones