-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crypto-js
In Lockfile
#9549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 699 kB ℹ️ View Unchanged
|
Closed
cemms1
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closing #9551 as this is a duplicate
abeddow91
approved these changes
Nov 20, 2023
this seems to be changing all the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
yarn
to update the lockfile and it made this change.The version of
crypto-js
listed as resolved hasn't changed, because we have it pinned viaresolutions
:dotcom-rendering/package.json
Lines 47 to 49 in cedf35a
I'm not sure why it's switched to listing a requirement on
crypto-js@^4.2.0
given that it's also downgraded the versionprebid
requires to^3.3.0
.I think this is related to #9475, which put
crypto-js
indotcom-rendering/package.json
'sresolutions
in the first place, and #9525 which moved that resolution to the top-levelpackage.json
. @mxdvl @abeddow91 any thoughts?@sndrs may also be interested in this.