Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hover buttons to recipe cards #1577

Merged
merged 10 commits into from
May 10, 2024
Merged

Add hover buttons to recipe cards #1577

merged 10 commits into from
May 10, 2024

Commits on May 9, 2024

  1. Use function-as-child-component pattern for hover actions buttons

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    00e641f View commit details
    Browse the repository at this point in the history

  2. Factor pathing logic out of buttons so we can reuse them in other cards

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e4a0e42 View commit details
    Browse the repository at this point in the history

  3. Remove test for presence of Ophan button 

    As we're now using that logic within the cards themselves
    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    db60a76 View commit details
    Browse the repository at this point in the history

  4. Correct Ophan link

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    96e9db9 View commit details
    Browse the repository at this point in the history

  5. Add leading slash to Ophan 

    Previously added by adding the guardian URL to the path and passing the URL through 'getPaths', which is unnecessary
    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2f26cfa View commit details
    Browse the repository at this point in the history

  6. Add overlay buttons to Recipe container card

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6d9403f View commit details
    Browse the repository at this point in the history

  7. Add clipboard callback to feed items

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8ffd8ba View commit details
    Browse the repository at this point in the history

  8. Move to specific render prop

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    20a804b View commit details
    Browse the repository at this point in the history

  9. ID of feed item is actually href – correct in follow up PR

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9e87c1a View commit details
    Browse the repository at this point in the history

  10. Add type for ChefFeedItem

    @jonathonherbert
    jonathonherbert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ba547e5 View commit details
    Browse the repository at this point in the history