Use npm rather than yarn in the root directory
#1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
force-pushed
the
cemms1/use-npm-at-root
branch
from
938460f
to
67973b1
Compare
|
Sorry for adding the yarn lock file, thanks for tidying it up Charlotte. It is unfortunate that this application uses Yarn and NPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
A
yarn.lockfile was added in this recent PR but there was already apackage-lock.jsonfile at the same level. I received a warning when installing dependencies in the root directory because of this.This PR removes the newer yarn lock file in favour of the existing npm package-lock one.
Implementation notes
Checklist
General
Client