Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update election notifications title #1587

Merged
merged 1 commit into from
May 23, 2024

Conversation

frankie297
Copy link
Contributor

What's changed?

Editorial want to reinstate the UK General Election breaking news alert, the hardcoded title was still referring to the last general election in 2019. This PR updates it to be "UK general election"

Implementation notes

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@frankie297 frankie297 requested a review from a team as a code owner May 23, 2024 16:28
Copy link
Contributor

@fredex42 fredex42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frankie297 frankie297 merged commit 1375276 into main May 23, 2024
9 checks passed
@frankie297 frankie297 deleted the fh-reinstate-general-election-alert branch May 23, 2024 16:40
@prout-bot
Copy link

Overdue on PROD (merged by @frankie297 30 minutes and 3 seconds ago) What's gone wrong?

@davidfurey
Copy link
Member

@frankie297 it looks like your build failed in main. Might just be a flaky test. Probably worth triggering the github action again

@prout-bot
Copy link

Seen on PROD (merged by @frankie297 114 hours, 14 minutes and 13 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants