Add overrides for the Chef card #1589
Merged
Commits on Jun 20, 2024
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
-
set criteria by collection type, style portrait thumbnails, validate …
…on drop (#1591) * use hard coded constant so all trails are required to be portrait * allow grid to select either image type, add state for the dimension of the selected replacement image, use to style the ImageContainer * bug fix? aspect ratio test should use absolute difference * use the criteria to set the gird url, not a separate prop * export the default trail image criteria from constants * remove unused imports * shorted var name, comments about use of constant criteria * add selectCollectionType selector * provide the collection type to the InputImage * add feature switch for whether to allow portrait crops * if the feature switch is enabled, set criteria based on collection type * dont change the FeatureSwitch class - just hide the new one client-side * provide criteria to slideshow * dont need state for imageDims - can get from props.input.value * remove collection type from render * use horrendous css funcions to style the image containers for small portraits in slideshows * wrangle the css for ImageContainer * move the image container to own file * validate image error distinguishes between 'no crops' and 'no matching crops' * dont use the default criteria * move constants to constants/image * Card components check the collection type to set criteria for image drops * add TO DO about dragging images from card to card * cards check replacement image dimensions and style thumbnails to display portraits right * validate dimensions of incoming dragged images from other cards * undo switch change * more coherent comments * update tests to account for more specific error messaging * message correctly when crops fail validation of a criteria without aspect ratio * refactor validation to reduce duplication of dimension criteria checks * add a crop icon next to the Collection title if it uses 5:4 crops * remove import * don't show the crop icon with feature switch off * remove test value from COLLECTIONS_USING_PORTRAIT_TRAILS * define type for empty string array
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.