Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for collections using portrait trails #1590

Merged
merged 8 commits into from
Jun 10, 2024
Merged

allow for collections using portrait trails #1590

merged 8 commits into from
Jun 10, 2024

Commits on Jun 4, 2024

  1. use hard coded constant so all trails are required to be portrait

    @dblatcher
    dblatcher committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    82c57d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. allow grid to select either image type, add state for the dimension o… 

    …f the selected replacement image, use to style the ImageContainer
    @dblatcher
    dblatcher committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    697be74 View commit details
    Browse the repository at this point in the history

  2. bug fix? aspect ratio test should use absolute difference

    @dblatcher
    dblatcher committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f81efff View commit details
    Browse the repository at this point in the history

  3. use the criteria to set the gird url, not a separate prop

    @dblatcher
    dblatcher committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    cdfd2d6 View commit details
    Browse the repository at this point in the history

  4. export the default trail image criteria from constants

    @dblatcher
    dblatcher committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    32be7d8 View commit details
    Browse the repository at this point in the history

  5. remove unused imports

    @dblatcher
    dblatcher committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    3a1cb1b View commit details
    Browse the repository at this point in the history

  6. shorted var name, comments about use of constant criteria

    @dblatcher
    dblatcher committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    fa50870 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. dont need state for imageDims - can get from props.input.value

    @dblatcher
    dblatcher committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e18ff39 View commit details
    Browse the repository at this point in the history