📌 load pinboard for V2 fronts tool if user has Pinboard permission (and feature switch on) #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
pinboard/initial-integration
branch
2 times, most recently
from
eec87c3
to
1a2913a
Compare
twrichards
force-pushed
the
pinboard/initial-integration
branch
3 times, most recently
from
650c551
to
7b2192a
Compare
6 tasks
twrichards
changed the title
andrew-nowak
approved these changes
Oct 15, 2024
twrichards
force-pushed
the
pinboard/initial-integration
branch
from
c48e31d
to
6edc7f1
Compare
…has (temporary) feature switch on
…pinboard permission though)
twrichards
force-pushed
the
pinboard/initial-integration
branch
from
6edc7f1
to
fcf5615
Compare
|
Seen on PROD (merged by @twrichards 6 minutes and 59 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This integrates https://github.com/guardian/pinboard in its current form, IF both...
/v2/featuresto see features switches)IMPORTANT: this switch is ignored in all envs except PROD, i.e. pinboard is loaded in CODE etc. if the user has pinboard permission
This is just the initial integration phase, and hopefully some additional/deeper integrations will follow (mostly on the pinboard side most likely - see guardian/pinboard#312 plus #1695).
Implementation notes
Checklist
General
Client