Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fairground] Hide config fields if scrollable small container #1682

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Georges-GNM
Copy link
Contributor

@Georges-GNM Georges-GNM commented Oct 8, 2024

What's changed?

Part of this ticket

There's a few options which we don't support in the scrollable/small container, and so want to hide in the config tool.

image

Implementation notes

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@Georges-GNM Georges-GNM changed the title Hide config fields if scrollable small container [Fairground] Hide config fields if scrollable small container Oct 8, 2024
@Georges-GNM Georges-GNM marked this pull request as ready for review October 8, 2024 13:44
@Georges-GNM Georges-GNM requested a review from a team as a code owner October 8, 2024 13:44
@Georges-GNM Georges-GNM merged commit 7eb334d into main Oct 8, 2024
12 checks passed
@Georges-GNM Georges-GNM deleted the gl/scrollable-small-config-requirements branch October 8, 2024 14:20
@prout-bot
Copy link

Seen on PROD (merged by @Georges-GNM 6 minutes and 56 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants