Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More palatte items for feast collection branding #1696

Merged
merged 2 commits into from
Oct 15, 2024
Merged

More palatte items for feast collection branding #1696

merged 2 commits into from
Oct 15, 2024

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Oct 15, 2024 •
edited
Loading

What's changed?

Feast-collection branding to expand by adding more items in the palatte.
reference: https://trello.com/c/RWjULodi/3332-more-items-to-add-in-the-palatte-in-feast-collection-branding

image

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Deploy build 8569 of cms-fronts::facia-tool to CODE

All deployment options

From guardian/actions-riff-raff.

@Divs-B Divs-B marked this pull request as ready for review October 15, 2024 09:57
@Divs-B Divs-B requested a review from a team as a code owner October 15, 2024 09:57
@Divs-B Divs-B requested a review from fredex42 October 15, 2024 10:08
fredex42
fredex42 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@fredex42 fredex42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Divs-B Divs-B merged commit dfe4a52 into main Oct 15, 2024
12 checks passed
@Divs-B Divs-B deleted the db/more-palatte-feast-collection-branding- branch October 15, 2024 10:59
@prout-bot
Copy link

Seen on PROD (merged by @Divs-B 7 minutes and 31 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredex42 fredex42 fredex42 approved these changes

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Divs-B @prout-bot @fredex42