Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add items to feast-collection palatte #1702

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Oct 18, 2024

What's changed?

Recent request to add items to Palatte for feast collection branding.

refernce: https://trello.com/c/ysz5pJHN/3340-more-to-feast-collection-branding

image

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@Divs-B Divs-B requested a review from a team as a code owner October 18, 2024 13:54
@Divs-B Divs-B requested a review from fredex42 October 18, 2024 13:55
Copy link
Contributor

@fredex42 fredex42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of grammar fixes but otherwise looks fine

@@ -81,6 +81,21 @@ export const chefPalettes: PaletteOption[] = [
];

export const feastCollectionPalettes: PaletteOption[] = [
{
id: 'apples_pears',
name: 'Apples pears',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apples & Pears maybe?

@@ -231,6 +246,21 @@ export const feastCollectionPalettes: PaletteOption[] = [
},
imageURL: 'https://uploads.guim.co.uk/2024/10/15/Cheeses.png',
},
{
id: 'coffee_donuts',
name: 'Coffee donuts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, maybe Coffee & Donuts?

id: 'rice',
name: 'Rice',
id: 'potatos',
name: 'Potatos',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently should be Potatoes (I had to look this up! 😁 https://www.dictionary.com/browse/potato)

@Divs-B Divs-B requested a review from fredex42 October 21, 2024 09:21
@Divs-B Divs-B merged commit 395f6b1 into main Oct 21, 2024
12 checks passed
@Divs-B Divs-B deleted the db/more-to-add-feast-collection-branding branch October 21, 2024 09:45
@prout-bot
Copy link

Seen on PROD (merged by @Divs-B 1 hour, 29 minutes and 26 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants