Date ordering preference for recipes

[fredex42]

What's changed?

• Compatibility with https://github.com/guardian/recipe-search-backend/pull/48, which adds the ability to prefer most recent recipes in the search results
• Fix long-standing bug where the search results disappear when recipes are loaded in from the clipboard or a container
• Adds the option to completely override the feed item body in FeedItem
• Optionally shows the modified and last published times for recipes in the Feed

Implementation notes

See the recipe-search-backend PR for an explanation of what "prefer" actually means

Checklist

General

• 🤖 Relevant tests added - None of the touched code currently has tests
• ✅ CI checks / tests run locally
• 🔍 Checked on CODE

Client

• 🚫 No obvious console errors on the client (i.e. React dev mode errors)
• 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
• 📷 Screenshots / GIFs of relevant UI changes included

[github-actions]

Deploy build 8599 of cms-fronts::facia-tool to CODE

All deployment options

• Deploy build 8599 of cms-fronts::facia-tool to CODE
• Deploy parts of build 8599 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[emdash-ie]

A couple of questions, but happy for you to merge!

[emdash-ie]

Calling this noPinboard feels like a bit of a double negative: noPinboard={true} takes me a second to think about. Could we make it showPinboard or enablePinboard?

[fredex42]

I know what you mean.... the reason I did it like this is because the pinboard changes are nothing to do with me so it felt better to keep the "default" behaviour to show pinboard (as I don't know what else that may affect) and set the override to hide it rather than vice-versa

[emdash-ie]

You could have the prop default to true if not specified, no?

[emdash-ie]

To be more explicit about how unknown values are handled, could we add a default case here?

Suggested change

	case 'default':
	return undefined;
	case 'default':
	default:
	return undefined;

[emdash-ie]

Using an uppercase R here feels inconsistent. I suppose it’s signalling that this option isn’t a field name? I think I’d still prefer lowercase.

[Divs-B]

I tested on Most recent published with search word Salad but result is not changing for me the one I got earlier is the same I am getting on selecting recent published too and it seems they are not in expected order for published?:

Network payload for search endpioint can be seen as : {queryText: "Salad", uprateByDate: "publishedDate", noStats: true}
and with response as:

Let me know if I have missed anything. thanks.
Note: this is I checked locally so pointing to CODE recipe.

[Divs-B]

When always show date is ON, few recipes are not showing dates under their titles.
One recipe where date is not mentioned it is not available also when clicked to view(we need to check this if recipe is not available then how we can show that recipe in the feed it shud be under Recipe not found i think, but can check in detail).
Here recipe: Grilled nectarine & burrata salad with pickled onions, tomato and mint which is not available when click to view.

---

And this one: this has no dates as well but this recipe is available when click to view.