correctly pass urlPath to FeedItem, rather than using liveUrl
#1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce that is prefixed by hostname etc.
twrichards
force-pushed
the
pass-urlPath-correctly-to-FeedItem
branch
from
4f28e0a
to
fced06e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1680 I rather naively passed
liveUrlto the newly requiredurlPathprop ofHoverActionsButtonWrapper, without realisingliveUrlis prefixed by hostname etc.This PR corrects that by passing
urlPathexplicitly intoFeedItem. This means that feed items get a working pinboard button (see guardian/pinboard#312).