Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Thumbnail image to DCR model for Audio Articles #27487

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add Thumbnail image to DCR model for Audio Articles #27487

wants to merge 9 commits into from

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Sep 17, 2024 •
edited
Loading

What is the value of this and can you measure success?

Add the thumbnail image to the DCR json for the audio Article

What does this change?

The Json sent for audio articles now contains a new optional field audioArticleImage

Screenshots

Before After
Screenshot 2024-09-17 at 11 12 21 Screenshot 2024-09-17 at 11 18 32

Checklist

  • Tested locally, and on CODE if necessary
  • Will not break dotcom-rendering

@oliverabrahams oliverabrahams marked this pull request as ready for review September 17, 2024 10:24
@oliverabrahams oliverabrahams requested a review from a team as a code owner September 17, 2024 10:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Deploy build 2938 of dotcom:frontend-all to CODE

All deployment options

From guardian/actions-riff-raff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliverabrahams