Container spacing fixes for video release #5422
Conversation
…spacing Conflicts: common/app/assets/stylesheets/theme/_tones.scss
| @@ -32,11 +30,14 @@ | |||
| @mixin facia-container--layout-front { | |||
| .facia-container--layout-front { | |||
| .facia-container__inner { | |||
| @include mq(gs-span(7) + $gs-gutter*3) { | |||
There was a problem hiding this comment.
Why is this off piste, or not defined as a tweakpoint inside _vars.scss?
|
👍 Thanks for doing this. As you mention in the PR notes, I'm happy to ship this tonight, and you can resolve the comments in another PR tomorrow. |
|
Seems like the build failure is a Sass linting error. I'll investigate and fix. |
|
Both locally and on TeamCity i'm getting a Sass lint error on this branch, but it doesn't seem to be a normal failure (i.e. on a line number specifying the rule broken), instead the task just seems to be bombing out and throwing a not that helpful message. >> scss-lint failed with error code: 1
>> and the following message:Error: Command failed:
>> 1 files are lint freeI'm suspicious that this may be related @kaelig's earlier of Sass and scss-lint today in #5393 It's too late to debug this evening, so am afraid I will wait until the morning. |
|
Many thanks for the comments at such a late hour. I've fixed the scss-lint warnings and will update the node module tomorrow. Sorry about that. Good point about the breakpoint naming in
It probably will take a medium-to-big PR to do that, but at least I won't be leaving dead bodies behind me when I go on holiday :) You should be able to merge now. |
Container spacing fixes for video release
Container spacing pr fixes - follow up with #5422
Right in time for release!
If someone from the content stream wants to ship it tonight, feel free to do so.
facia-container__innerfrom going full width in-between major breakpointsHad to apply fixes in a few other places to cascade these styles when other components were mimicking them.
Basically, makes the video page look much better (see containers below the content itself):
And the network front:
Now for a standard article: