Migrate giant to github actions #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsavar
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Looks good!
I think it's worth separating out the frontend and the backend into separate steps rather than having them in the same script; that would allow you to do some interesting stuff with caching (happy to work on it during 10% 😄). But as a first step this seems to work fine.
| @@ -21,7 +21,10 @@ popd | |||
| cp -r frontend/build/* backend/public | |||
| # Replace the symbolic link we use in dev with the actual file. | |||
| # On Teamcity the JDeb build doesn't seem to follow the symbolic link while packaging, weirdly | |||
| cp frontend/node_modules/pdfjs-dist/build/pdf.worker.min.js backend/public/third-party/pdf.worker.min.js | |||
| # NOTE: On Github actions this seems to work, and in fact it will complain if you try and run the below line | |||
There was a problem hiding this comment.
I can't comment on parts of this file that weren't modified in this PR, but lines 4-11 in this script are made redundant by actions/setup-node@v3 in the workflow so they can be removed I think
Lines 4 to 11 in 958316e
scripts/teamcity.sh
Outdated
There was a problem hiding this comment.
This should probably be renamed to ci.sh since it no longer runs in TeamCity.
.github/workflows/build.yml
Outdated
|
|
||
| # Configuring caching is also recommended. | ||
| # See https://github.com/actions/setup-java | ||
| - name: Setup Java 8 |
There was a problem hiding this comment.
Suggested change
| - name: Setup Java 8 | |
| - name: Setup Java 11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a github actions workflow to build giant.
The only change I had to make was to comment out this bit where we manually copy the compiled pdf.worker.min.js file as github actions appears to not have the same issue that teamcity did where it didn't follow the symbolic link associated with the file.
Otherwise this is a fairly standard node/scala gha build
Note that these builds are significantly slower than teamcity- between 13 and 16 minutes up from 7-10 on teamcity. I have emailed DevX asking to use the larger github actions runners.
How to test
I've tested this on playground by deploying a version generated by github actions, it seems to work (including the pdf worker!)
How can we measure success?