upgrade d3 from 4.13.0 to v7.9.0 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominickendrick
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR upgrades d3 library. The only usage of this library is in https://github.com/guardian/giant/blob/main/frontend/src/js/components/EmailBrowser/Timeline.js#L5
I tested this locally and the email threads are rendering correctly.
Why
We need to upgrade d3-colour to 3.1.0 due to vulnerability https://github.com/guardian/giant/security/dependabot/2
But d3 library depends on d3-colour and to be able to update d3-colour we had to upgrade d3 from v4 to v7.