Add confirmation modal for removing from workspace #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjisound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a confirmation modal for removing items from workspace. If it's a single file to be removed, the confirmation message displayed to user is:
"This will remove the file [filename] from the current workspace. It cannot be undone. Are you sure you want to proceed?"
If it’s any other type (folder, zip, email database that can be “expanded” etc), the message is:
"This will remove the selection [item name] and everything nested inside it from your workspace. It cannot be undone. Are you sure you want to proceed?"
The PR also updated the delete modal message to be consistent with the remove modal.
How to test
Tested locally