Prefer select crops button to disabled button in iframe

guardian · Jan 22, 2025 · 658dcb8 · 658dcb8
1 parent 6260b5f
commit 658dcb8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/...a/public/js/components/gr-batch-export-original-images/gr-batch-export-original-images.js b/...a/public/js/components/gr-batch-export-original-images/gr-batch-export-original-images.js
@@ -10,11 +10,11 @@ batchExportOriginalImages.controller('grBatchExportOriginalImagesCtrl', [
     function($q, $scope, $rootScope, $state, mediaCropper) {
         let ctrl = this;
 
-        const checkForFullCrops = () => ctrl.images.every(
+        const checkForFullCrops = () => ctrl.images.filter(
             image => image.data.exports.some(
               crop => crop.specification.type === 'full'
             )
-        );
+        ).size;
 
         const croppable = () => ctrl.images.filter(
           image => image.data.valid && image.data.softDeletedMetadata === undefined &&
@@ -24,17 +24,19 @@ batchExportOriginalImages.controller('grBatchExportOriginalImagesCtrl', [
         );
 
         $scope.$watchGroup(['ctrl.images', 'ctrl.cropping'], () => {
-          ctrl.allHaveFullCrops = checkForFullCrops();
+          const numberWithFullCrops = checkForFullCrops();
+          const allHaveFullCrops = numberWithFullCrops === ctrl.images.size;
+          const someHaveFullCrops = numberWithFullCrops > 0;
           const croppableImages = croppable();
 
           ctrl.allCroppable = croppableImages.size === ctrl.images.size;
           ctrl.noneCroppable = croppableImages.size === 0;
 
           const pageIsEmbedded = window.parent !== window;
 
-          ctrl.canBatchCrop = !ctrl.allHaveFullCrops && !ctrl.cropping && !ctrl.noneCroppable;
-          ctrl.cropDisabled = !ctrl.allHaveFullCrops && !ctrl.cropping && ctrl.noneCroppable;
-          ctrl.canSelectCrops = ctrl.allHaveFullCrops && !ctrl.cropping && pageIsEmbedded;
+          ctrl.canBatchCrop = !ctrl.cropping && !allHaveFullCrops && !ctrl.noneCroppable;
+          ctrl.canSelectCrops = !ctrl.cropping && !ctrl.canBatchCrop && someHaveFullCrops && pageIsEmbedded;
+          ctrl.cropDisabled = !ctrl.cropping && !ctrl.canBatchCrop && !ctrl.canSelectCrops && ctrl.noneCroppable && !allHaveFullCrops;
         }, true);
 
         ctrl.callBatchCrop = function() {

diff --git a/kahuna/public/stylesheets/main.css b/kahuna/public/stylesheets/main.css
@@ -651,11 +651,14 @@ button[disabled],
 .inner-clickable {
     height: 100%;
     display: inline-flex;
+    gap: 2px;
     align-items: center;
 }
 
 .inner-clickable--disabled {
-  opacity: 0.7;
+  color: #9e9e9e;
+  fill: #9e9e9e;
+  cursor: default;
 }
 
 .button-right-side {
@@ -1421,6 +1424,7 @@ textarea.ng-invalid {
 
 gr-batch-export-original-images .batch-export-original-images {
   padding: 0 10px;
+  height: 100%;
 }
 
 .results-toolbar-item {