make reaper schedule behave more like cron #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
reaper-cron-like-schedule
branch
2 times, most recently
from
4fcaca6 to
302ea86
Compare
… is redeployed, i.e. behave more like cron
twrichards
force-pushed
the
reaper-cron-like-schedule
branch
from
302ea86 to
a145fba
Compare
dblatcher
approved these changes
Nov 24, 2023
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
Seen-on-kahuna
Seen-on-cropper
Seen-on-metadata-editor
and removed
Pending-on-cropper
Pending-on-metadata-editor
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on cropper, kahuna, auth, metadata-editor (merged by @twrichards 9 minutes and 55 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-usage
Seen-on-image-loader
and removed
Pending-on-image-loader
Pending-on-usage
labels
|
Seen on image-loader, usage (merged by @twrichards 10 minutes and 3 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-leases
Seen-on-media-api
and removed
Pending-on-leases
Pending-on-media-api
labels
|
Seen on leases, media-api (merged by @twrichards 10 minutes and 8 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-collections
Seen-on-thrall
and removed
Pending-on-collections
Pending-on-thrall
labels
|
Seen on collections, thrall (merged by @twrichards 10 minutes and 15 seconds ago) Please check your changes! |
|
Seen on collections (merged by @twrichards 10 minutes and 15 seconds ago) Please check your changes! |
|
Seen on collections, thrall (merged by @twrichards 10 minutes and 16 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the
SoftReapingTooMuch&HardReapingTooMuchalarms (added in https://github.com/guardian/editorial-tools-platform/pull/712) were firing on re-deploys of the grid, since reaper was running with no delay on startup then every 15mins thereafter. We decided that best to ensure reaper only runs at the interval specified as that makes it easier to reason about (and changing the alarms would be hard without compromising their utility/promptness).What does this change?
This introduces a util function for finding the time/duration until the next instance of an interval, past the hour... e.g. if 'now' is 11:11:31 then the next instance of the interval will be 11:15:00 and so the duration until then is 3min 29sec. This functionality has tests 🎉 .
This function is then used for the
initialDelaywhen starting the reaper schedule inthrall.How should a reviewer test this change?
Do multiple deploys to
TESTin quick succession and see that reaper still only runs (can be observed via CloudWatch metrics:SoftReaped&HardReaped) on 00, 15, 30 & 45 mins past the hour.