Autocomplete credit in search results panel

[kenoir]

Currently autocomplete doesn't function in the batch editing pane, and image viewer.

• Investigate using https://material.angularjs.org/latest/ (see below)

This PR uses the angular-xeditable typeahead element to maintain feature parity with the other xeditable elements in this panel.

[kenoir]

Here's it working with Angular Material:

I came across a couple of issues:

• The styling is quite aggressive and overrides some root elements that need to be overridden to keep our "grid" style.
• The "required" functionality isn't working in the most recent stable release for the autocomplete element, (md-autocomplete does not work with ng-messages validation angular/material#3401).
• The md-model-options to update on blur don't seem to work.

See: https://github.com/guardian/grid/compare/angular-md-autocomplete

[jamesgorrie]

Did copy and paste work for the one we have?
Nice to have material design, but not if it takes ages.

[kenoir]

I don't think it's a matter of taking ages, rather it's intended to be used in its entirety, so mixing and matching elements looks (and behaves) strangely.

There is also the matter of offering all the features that we want raised by the missing or broken functionality.

[kenoir]

Working on search screen:

[theefer]

Great use of the plugin. When is it evaluated though? Just want to check it doesn't query the API on every Angular $digest cycle!

[kenoir]

Looks like the way typeahead is implemented it hooks into the $parsers for the element the directive is attached to: https://github.com/angular-ui/bootstrap/blob/49e73a89f36b1c44d7547b8910bcb17e96135294/src/typeahead/typeahead.js#L195

Which I think means it's only modified when its' value changes.

[theefer]

OK. One way to test if you're not sure would be to trigger other digest cycles, e.g. select another image, etc, and see if it queries again. But it sounds like it wouldn't.

[kenoir]

@theefer @akash1810 regarding implementing this on the image page. Could we discuss reusing the panel here?

I remember @paperboyo mentioning that the edit panel in Lightroom was the same in the search view / individual item view, might make more sense if both views have the same functionality, (and save us maintaining both views).

If we reckon it's worth doing, let's do it in another PR.

[theefer]

You might want to talk to @akash1810, they intrinsically have slightly different interaction patterns. +1 to reuse but not sure at which level it makes most sense.

[akash1810]

Discussed IRL. 👍 to reuse!

Would also get a quick win in terms of displaying more metadata in selection mode; wether its editable or not is another question though - would you want to batch edit the location?

[theefer]

Worth shipping this first? 👍

[paperboyo]

would you want to batch edit the location

Yeah - by dropping them all on a map 😜 !

Cool! A platonic +1 for reuse!

[kenoir]

@theefer yes.

[kenoir]

Looks good in test, merging.