-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scribe #467
add scribe #467
Changes from all commits
f8af858
07af6c0
bafc5a4
72d24ef
6089e6c
c27603c
2e5186e
9e83161
a1d5a05
6fb0658
c74c838
e77e053
afbfd88
c14d11b
6f9f81c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,6 +74,11 @@ | |
"redux": "^3.6.0", | ||
"redux-thunk": "^2.1.0", | ||
"reqwest": "^2.0.5", | ||
"scribe": "guardian/scribe#fcf4e16", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are we using scribe on this commit rather than a release? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because scribe hasn't been released for a while so newer versions are not available on npm. I could look into releasing it later today. |
||
"scribe-plugin-keyboard-shortcuts": "^0.1.1", | ||
"scribe-plugin-link-prompt-command": "^1.0.0", | ||
"scribe-plugin-sanitizer": "^0.1.10", | ||
"scribe-plugin-toolbar": "^1.0.0", | ||
"valid-url": "^1.0.9" | ||
}, | ||
"version": "1.0.0", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be moved here so we can use the builder pattern like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, this becomes difficult because getting the youtube description requires querying capi so I'm just going to leave this here.