Skip to content

Commit

Permalink
Fix compatibility-version-numbering - skip über jar
Browse files Browse the repository at this point in the history
`sbt-version-policy` kept on deciding that every release (eg
https://github.com/guardian/play-secret-rotation/releases/tag/v6.0.0 )
needed a 'MAJOR' version bump, even when there were no changes between
releases:

v5.0.0...v6.0.0

This is due to our submodule `aws-parameterstore-lambda` being released
as an über jar (with `sbt-assembly`) and the issue
scalacenter/sbt-version-policy#190 .

I think setting `versionPolicyAssessCompatibility / skip := true` may
well be enough to fix the issue, though only if
`fromAggregatedAssessedCompatibilityWithLatestRelease()` respects it-
lets see if it will!
  • Loading branch information
rtyley committed Dec 7, 2023
1 parent f19e8ca commit d3240b3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions aws-parameterstore/lambda/build.sbt
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// replace the conventional main artifact with an uber-jar
addArtifact(Compile / packageBin / artifact, assembly)

// see https://github.com/scalacenter/sbt-version-policy/issues/190
versionPolicyAssessCompatibility / skip := true

assembly / assemblyMergeStrategy := {
{
case PathList("META-INF", _ @ _*) => MergeStrategy.discard
Expand Down

0 comments on commit d3240b3

Please sign in to comment.