Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move To scala-guild Snyk Org #494

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Move To scala-guild Snyk Org #494

merged 1 commit into from
Sep 12, 2024

Conversation

JamieB-gu
Copy link
Contributor

This project is maintained by @guardian/scala-guild

@JamieB-gu JamieB-gu requested a review from a team as a code owner September 10, 2024 11:53
Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was interested to see that the snyk job ran on this pull request – handily, this meant that the project has shown up in the snyk dashboard and we can see it’s working correctly. However, presumably the snyk job should only run on main? That’s how our other repositories are set up, and I don’t think Snyk handles runs from multiple branches nicely.

So: mind if we restrict the push trigger to just the main branch?

@JamieB-gu JamieB-gu merged commit a8f0ff4 into main Sep 12, 2024
2 checks passed
@JamieB-gu JamieB-gu deleted the scala-guild-snyk-org branch September 12, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants