compute the doNotProcessUntil timespan for cancellation saves #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrf1
reviewed
Nov 28, 2024
| @@ -79,16 +79,30 @@ object NotificationHandler extends CohortHandler { | |||
| item: CohortItem, | |||
| subscription: ZuoraSubscription | |||
| ): ZIO[CohortTable with Zuora, Failure, Unit] = { | |||
| // Known keys for this mapping can be found in the BillingPeriod object | |||
There was a problem hiding this comment.
not very important, but a more robust approach is to use BillingPeriod.fromString and have an exhaustive pattern match instead of a Map
There was a problem hiding this comment.
Actually you are right, let me do that....
There was a problem hiding this comment.
ah, I was imagining a match on BillingPeriod -
def billingPeriodToInt(period: BillingPeriod): Int =
period match {
case Monthly => 1
case Quarterly => 3
case SemiAnnual => 6
case Annual => 12
}
So that you can call:
BillingPeriod.billingPeriodToInt(BillingPeriod.fromString(billingPeriod))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the logic of the interaction between subscriptions in "cancellation save" status and a pending price migration, a feature that we added for Supporter+ 2024.
In this update the time that the item is going to wait before being re-estimated, is computed as a function of the billing period. In essence we want to wait (at least) two billing periods before notifying the user of a price migration, instead of 6 months.