Test CI formatting check #73
Conversation
Indented this line with a tab, the rest of this file is indented with spaces.
|
As shown by the build failures on the three commits, our CI is not checking the formatting of our files with our prettier config. Whatever checking it is doing appears insufficient, as well – I think we would want our formatting check to at least complain about mixed tabs-and-spaces and negative indentation of continued lines. |
|
Added two more commits, showing the CI check is not complaining about odd spacing in the middle of the line (including a tab!), nor about trailing space at the ends of lines. |
|
As a test, I’ve cherry-picked the commits from #65 that originally configured eslint to run prettier. The build failure shows that this successfully runs prettier with our config. |
This reverts commit c2f7a26.
This reverts commit a40cb4b.
I copied these [from dotcom-rendering](https://github.com/guardian/dotcom-rendering/blob/f9f1c28066c048a1b4c281514d69382f220d9a19/package.json#L19-L20) – I figure it’s probably good to be consistent with how they do things. In particular, I’m adding these because I can’t get nx to run prettier with the same config as when I run it directly (I don’t even know if it’s definitely running prettier!): running `npm run format:check` with these changes warns that 102 files need formatting, whereas running `npm run nx format:check` only says two files need formatting (package-lock.json and package.json). Cherry picked from commit 4dfe61b.
To ensure the files are formatted with prettier, this commit runs the format:check script in the github actions build. Cherry picked from commit 1e57fe7.
`npm ci` installs the dependencies, e.g. prettier, so the format check fails because prettier can’t be found! Cherry picked from commit 9ae4fd1.
|
As a second test, I reverted the eslint config and restored the check that runs prettier directly – that also fails the build, correctly detecting the formatting errors. |
|
Closing this PR as it was just for testing |
This PR makes a number of weird formatting changes, to test whether the CI is checking formatting.