Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove security groups lambda #1183

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat: remove security groups lambda #1183

merged 2 commits into from
Dec 17, 2024

Conversation

tjsilver
Copy link
Contributor

@tjsilver tjsilver commented Dec 5, 2024 •
edited
Loading

What does this change?

Removes the security groups lambda and all code relating to lambdas as this is the only remaining lambda.

What is the value of this?

We are deprecating Security HQ, and the team has concluded that this lambda is not providing enough value to justify its continued existence and maintenance cost.

Will this require CloudFormation and/or updates to the AWS StackSet?

Yes.

Will this require changes to config?

Tests

  • Run security hq app locally
  • Redeploy stackset and check that IAM remediation functionality is still working

@tjsilver tjsilver changed the title wip: feat: remove security groups lambda feat: remove security groups lambda Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

Deploy build 3016 of security-hq to CODE

All deployment options

From guardian/actions-riff-raff.

@tjsilver tjsilver requested review from adamnfish and a team December 11, 2024 11:40
@tjsilver tjsilver marked this pull request as ready for review December 11, 2024 11:41
adamnfish
adamnfish requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@adamnfish adamnfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I think we need to leave the "watched account access policy" as-is for now, ahead of actually disabling the data collection in the Security HQ app itself.

build.sbt Show resolved Hide resolved
hq/public/javascripts/app.js Show resolved Hide resolved
hq/app/model/models.scala Show resolved Hide resolved
cloudformation/watched-account.template.yaml Outdated Show resolved Hide resolved
@tjsilver tjsilver requested a review from adamnfish December 16, 2024 12:34
adamnfish
adamnfish approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@adamnfish adamnfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@tjsilver tjsilver merged commit e5a12dc into main Dec 17, 2024
4 checks passed
@tjsilver tjsilver deleted the ts/remove-lambda branch December 17, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamnfish adamnfish adamnfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjsilver @adamnfish