Fixes detection of report generation after the v2 SDK update #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the AWS v2 Java SDK update, the test of whether the report has finished being generated was broken. We correct this here so that we will detect a finished report. This will stop us getting rate limit errors, and restore IAM remediation functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the AWS v2 Java SDK update, the test of whether the report has finished being generated was broken. We correct this here so that we will detect a finished report.
This will stop us getting rate limit errors, and restore IAM remediation functionality.
What does this change?
The v1 SDK used a String for the status field, but in v2 this is an enum called
ReportType. We had a type error warning, but because this projefct does not have fatal warnings enabled it was easy to miss. This incorrect equality check means we will be constantly retrying the report generation check instead of proceeding to load the report.