Migrate super-mode-calculator from Teamcity to GitHub Actions #136
Conversation
LAKSHMIRPILLAI
force-pushed
the
lp-migrate-super-mode-calculator-to-githubActions
branch
from
6ecbb71
to
b52b40c
Compare
LAKSHMIRPILLAI
force-pushed
the
lp-migrate-super-mode-calculator-to-githubActions
branch
from
85d14e9
to
e48e7df
Compare
|
Deployed the changes to code via Riff-Raff without issues 
|
| @@ -6,7 +6,7 @@ deployments: | |||
| type: aws-lambda | |||
| parameters: | |||
| prefixStack: false | |||
| bucket: membership-dist | |||
There was a problem hiding this comment.
I realised something recently. The warning on this in Riff Raff says something like “and remove private information from git”. Until now I’ve taken that to mean “by doing this you will have removed private information from version-controlled files”, but I think it actually means “and once you’ve done this also remove the private information from the git history using something like the bfg”. It might be worth us checking with devx and arranging to do this for the ones we’ve updated over the last while. (It doesn’t need to block this PR though.)
| with: | ||
| cache: 'yarn' | ||
| cache-dependency-path: ./super-mode-calculator/yarn.lock | ||
| node-version: 14.16.0 |
There was a problem hiding this comment.
It looks like we a .nvmrc file in the repository. Setting the node-version-file input to actions/setup-node will allow us to track the version of node in a single place, the .nvmrc file.
node-version-file: super-mode-calculator/.nvmrc
LAKSHMIRPILLAI
deleted the
lp-migrate-super-mode-calculator-to-githubActions
branch
What are you doing in this PR?
Migrate super-mode-calculator from TeamCity to Github Actions.
Trello card: Here
Why are you doing this?
DevX is planning to retire TeamCity by the end of September 2023. All workflows will need to be migrated to Github Actions
The TeamCity agent count will be continually decreasing from June onwards, reaching 0 by the end of September. So the build queues and therefore the time it takes to be able to deploy might increase, if the job count does not decrease.
You should not use TeamCity for any new applications from now on.
Our main build service is now GitHub Actions. GitHub Actions documentation - GitHub Docs
We will all benefit from this move by being able to keep our CI builds as code, version controlled alongside its codebase, and having a reduced number of tools and access, all bundled under one vendor, with better analytics through CloudQuery and Grafana.
Furthermore, this change will help improve our resilience to supply chain threats particularly in the build process.
More detailed reasoning can be found in this proposal Using GitHub Actions for CI