Add a new endpoint GET /benefits/<identity id> to the user benefits API
#2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll be adding a new path shortly and I think it makes sense to keep this lambda separate as the auth is different.
We'll have a single index and zip file for this handler and the new one.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
I'd like to use a wildcard in the path here. According to https://aws.amazon.com/blogs/aws/api-gateway-update-new-features-simplify-api-development/ it should be possible.
4 tasks
tjmw
force-pushed
the
tw/user-benefits-lambda-by-path
branch
from
3e4bd57 to
73c5301
Compare
tjmw
changed the title
GuApiGatewayWithLambdaByPathGET /benefits/<identity id> to the user benefits API
tjmw
commented
Dec 20, 2024
| @@ -27,34 +27,20 @@ jest.mock('@modules/product-benefits/userBenefits', () => ({ | |||
| getUserBenefits: () => ['adFree'], | |||
| })); | |||
|
|
|||
| describe('handler', () => { | |||
| it('returns a 404 for an unrecognized path or HTTP method', async () => { | |||
There was a problem hiding this comment.
This diff is a bit messy but basically all that's happened here is the removal of the old 404 test, this now happens upstream and not in the lambda.
rupertbates
reviewed
Dec 20, 2024
rupertbates
reviewed
Dec 20, 2024
rupertbates
reviewed
Dec 20, 2024
|
|
||
| const userBenefitsResponse = await getUserBenefitsResponse( | ||
| stage, | ||
| new ProductCatalogHelper(await productCatalog.get()), |
There was a problem hiding this comment.
Maybe create a Lazy<ProductCatalogHelper> at the top level rather than a productCatalog and then creating a new helper every time?
rupertbates
reviewed
Dec 20, 2024
rupertbates
reviewed
Dec 20, 2024
| }; | ||
| } | ||
| }; | ||
| export { benefitsMeHandler } from './benefitsMe'; |
There was a problem hiding this comment.
Why do we need this file now?
There was a problem hiding this comment.
This acts as the single entry point for esbuild which gives access to both handlers (but means we can still keep the handlers in separate files).
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a new endpoint
/benefits/<identity id>which is auth'd using anx-api-keyheader (enforced in API Gateway). Because the auth is performed differently, at the API Gateway, I've migrated to using theGuApiGatewayWithLambdaByPathwith a lambda per endpoint.This will be called from support-frontend to prevent a user who already has a the
adFreebenefit from purchasing Guardian Ad-Lite.Note: in the first implementation the endpoint does not know anything about internal users
How to test
I've deployed to CODE and tested.
Note: this requires a dangerous deploy in Riff Raff because the old lambda is deleted.
How can we measure success?
Have we considered potential risks?
Images
Accessibility