Proxy Port Fixes #715
Merged
Proxy Port Fixes #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #707 |
bitmold
force-pushed
the
proxy_port_fixes
branch
from
81a5c1d to
b1f33b6
Compare
| extraLines.append("SafeSocks 0").append('\n'); | ||
| extraLines.append("TestSocks 0").append('\n'); | ||
| } else { | ||
| extraLines.append("SOCKSPort 0.0.0.0:").append(socksPortPref).append("\n"); |
There was a problem hiding this comment.
should isolate/ipv6 be added here too? 51216a4
There was a problem hiding this comment.
yes, thank you. added
|
5ba7ce9 has a missing symbol |
|
It looks like R.id.tvSnowflake is undefined |
|
This fixes the problem: syphyr@ef7d989 |
|
Thanks @syphyr , I just forgot to commit the XML file. I'll throw it up next time I'm online |
|
One other thing I noticed is that the version string is only showing up for obfs4 in "About" screen. |
|
Odd, I was seeing both versions. Will revisit when I commit the missing XML file ... |
bitmold
force-pushed
the
proxy_port_fixes
branch
from
15cbe18 to
13217fa
Compare
|
eh, guardianproject/tor-android#84 was merged and released? weren't these supposed to be together? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is dependent on guardianproject/tor-android#84 being released in tor-android and should not be merged until that is released
Fixes: #708 and #709