-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving module loader error messages #1501
Improving module loader error messages #1501
Conversation
e7b67d4
to
a4def07
Compare
a4def07
to
0942363
Compare
0942363
to
ba16c79
Compare
Alright. This should resolve the usability regression brought on in #1414, where |
modules/core/src/main/scala/dev/guardrail/generators/spi/FrameworkLoader.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1501 +/- ##
==========================================
+ Coverage 84.21% 84.32% +0.10%
==========================================
Files 92 93 +1
Lines 5569 5613 +44
Branches 153 159 +6
==========================================
+ Hits 4690 4733 +43
- Misses 879 880 +1
Continue to review full report at Codecov.
|
1) Monad was not what I wanted, I needed Applicative 2) "missing" needed to be a completely new identifier, not just whatever modules we have attempted so far
0f4ed70
to
2216df7
Compare
This is a pretty big change over how the loaders previously worked, the ergonomics aren't great currently right now, but tracking in parallel (applicative-style) gives us this reporting capability.