Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including available choices #1507

Merged

Conversation

blast-hardcheese
Copy link
Member

  • Instead of just highlighting which components did not have a module specified, collect the mapping of components to available choices to aide in the user choosing sensible values.

image

@blast-hardcheese blast-hardcheese added the enhancement Functionality that has never existed in guardrail label Jun 22, 2022
@blast-hardcheese blast-hardcheese added the minor Bump minor version label Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1507 (f0ee58f) into master (ead17ca) will increase coverage by 0.39%.
The diff coverage is 87.38%.

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
+ Coverage   84.32%   84.72%   +0.39%     
==========================================
  Files          93       93              
  Lines        5613     5661      +48     
  Branches      159      149      -10     
==========================================
+ Hits         4733     4796      +63     
+ Misses        880      865      -15     
Impacted Files Coverage Δ
...i/src/main/scala/dev/guardrail/cli/CLICommon.scala 85.10% <71.42%> (+20.40%) ⬆️
...ev/guardrail/generators/spi/ModuleLoadResult.scala 75.64% <84.61%> (+5.18%) ⬆️
...les/cli/src/main/scala/dev/guardrail/cli/CLI.scala 100.00% <100.00%> (ø)
...dules/core/src/main/scala/dev/guardrail/Args.scala 100.00% <100.00%> (ø)
.../dev/guardrail/generators/spi/AbstractLoader.scala 100.00% <100.00%> (ø)
...dev/guardrail/generators/spi/FrameworkLoader.scala 95.23% <100.00%> (+5.76%) ⬆️
.../guardrail/generators/spi/ModuleMapperLoader.scala 100.00% <100.00%> (ø)
...yncHttpClient/AsyncHttpClientClientGenerator.scala 94.27% <100.00%> (ø)
...nerators/java/dropwizard/DropwizardGenerator.scala 30.95% <100.00%> (ø)
...rs/java/dropwizard/DropwizardServerGenerator.scala 94.71% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead17ca...f0ee58f. Read the comment docs.

@blast-hardcheese blast-hardcheese merged commit 5179db5 into guardrail-dev:master Jun 23, 2022
@blast-hardcheese blast-hardcheese deleted the including-choices branch June 23, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Functionality that has never existed in guardrail minor Bump minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant