-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including available choices #1507
Merged
blast-hardcheese
merged 23 commits into
guardrail-dev:master
from
blast-hardcheese:including-choices
Jun 23, 2022
Merged
Including available choices #1507
blast-hardcheese
merged 23 commits into
guardrail-dev:master
from
blast-hardcheese:including-choices
Jun 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
blast-hardcheese
commented
Jun 22, 2022
- Instead of just highlighting which components did not have a module specified, collect the mapping of components to available choices to aide in the user choosing sensible values.
blast-hardcheese
added
the
enhancement
Functionality that has never existed in guardrail
label
Jun 22, 2022
blast-hardcheese
force-pushed
the
including-choices
branch
from
June 22, 2022 23:42
250d2af
to
fad1edb
Compare
blast-hardcheese
force-pushed
the
including-choices
branch
from
June 23, 2022 01:14
3da62aa
to
dee26a7
Compare
blast-hardcheese
force-pushed
the
including-choices
branch
from
June 23, 2022 01:19
dee26a7
to
79efb99
Compare
blast-hardcheese
force-pushed
the
including-choices
branch
from
June 23, 2022 04:28
7186a14
to
fdb52c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
==========================================
+ Coverage 84.32% 84.72% +0.39%
==========================================
Files 93 93
Lines 5613 5661 +48
Branches 159 149 -10
==========================================
+ Hits 4733 4796 +63
+ Misses 880 865 -15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.