Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refined types #1508

Conversation

stanislav-chetvertkov
Copy link
Contributor

No description provided.

@github-actions github-actions bot added core Pertains to guardrail-core scala-akka-http Pertains to guardrail-scala-akka-http scala-http4s Pertains to guardrail-scala-http4s scala-support Pertains to guardrail-scala-support labels Jun 23, 2022
@blast-hardcheese blast-hardcheese force-pushed the scala-refined-types branch 2 times, most recently from 173046d to e9c6893 Compare June 25, 2022 17:17
@blast-hardcheese
Copy link
Member

@stanislav-chetvertkov Wrapped up the PR, as per our discussion -- when you've got a chance to review, I'd appreciate it

@blast-hardcheese blast-hardcheese force-pushed the scala-refined-types branch 2 times, most recently from b744e1e to eb72258 Compare June 25, 2022 17:28
@blast-hardcheese
Copy link
Member

Reformatted, as well as moved top-level names to _root_ qualified names as to not conflict with names used in either specifications or custom user code

@blast-hardcheese blast-hardcheese added the minor Bump minor version label Jun 25, 2022
@blast-hardcheese blast-hardcheese removed the core Pertains to guardrail-core label Jun 25, 2022
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #1508 (d933bab) into master (7abcf08) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
+ Coverage   84.72%   84.80%   +0.08%     
==========================================
  Files          93       95       +2     
  Lines        5661     5707      +46     
  Branches      149      141       -8     
==========================================
+ Hits         4796     4840      +44     
- Misses        865      867       +2     
Impacted Files Coverage Δ
...ators/scala/akkaHttp/AkkaHttpClientGenerator.scala 94.93% <100.00%> (+0.09%) ⬆️
.../generators/scala/akkaHttp/AkkaHttpGenerator.scala 34.69% <100.00%> (+2.06%) ⬆️
...ators/scala/akkaHttp/AkkaHttpServerGenerator.scala 92.00% <100.00%> (+0.08%) ⬆️
.../generators/scala/CirceRefinedModelGenerator.scala 100.00% <100.00%> (ø)
...enerators/scala/circe/CirceProtocolGenerator.scala 92.70% <100.00%> (-0.40%) ⬇️
...rs/scala/circe/CirceRefinedProtocolGenerator.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7abcf08...d933bab. Read the comment docs.

@blast-hardcheese blast-hardcheese marked this pull request as ready for review June 26, 2022 06:36
@blast-hardcheese blast-hardcheese merged commit 3a94461 into guardrail-dev:master Jun 26, 2022
@blast-hardcheese blast-hardcheese added enhancement Functionality that has never existed in guardrail scala Broadly concerning Scala code generation or the generated Scala code labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Functionality that has never existed in guardrail minor Bump minor version scala Broadly concerning Scala code generation or the generated Scala code scala-akka-http Pertains to guardrail-scala-akka-http scala-http4s Pertains to guardrail-scala-http4s scala-support Pertains to guardrail-scala-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants