Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async-http-client to 2.12.3 #1669

Conversation

scala-steward
Copy link
Contributor

Updates org.asynchttpclient:async-http-client from 2.8.1 to 2.12.3.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (2.8.1).
You might want to review and update them manually.

project/src/main/scala/Build.scala
project/src/main/scala/modules/core.scala
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.asynchttpclient", artifactId = "async-http-client" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.asynchttpclient", artifactId = "async-http-client" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

@github-actions github-actions bot added java-dropwizard Pertains to guardrail-java-dropwizard chore labels Jan 7, 2023
@blast-hardcheese blast-hardcheese force-pushed the update/async-http-client-2.12.3 branch from 1cd980e to 514899c Compare October 19, 2023 03:24
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fa02cc3) 82.41% compared to head (514899c) 82.41%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          93       93           
  Lines        7326     7326           
  Branches      869      869           
=======================================
  Hits         6038     6038           
  Misses       1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blast-hardcheese blast-hardcheese merged commit 90aa6a8 into guardrail-dev:master Oct 19, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore java-dropwizard Pertains to guardrail-java-dropwizard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants