Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/Preparing for 1591 #1739

Conversation

blast-hardcheese
Copy link
Member

Misc cleanups, trying to rebuild momentum on this issue after a long break

@blast-hardcheese blast-hardcheese force-pushed the chore/preparing-for-1591 branch from 484592b to 5199509 Compare May 14, 2023 05:11
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 96.77% and project coverage change: -1.53 ⚠️

Comparison is base (ea609cb) 84.51% compared to head (5199509) 82.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
- Coverage   84.51%   82.99%   -1.53%     
==========================================
  Files          95       95              
  Lines        5838     5839       +1     
  Branches      583      562      -21     
==========================================
- Hits         4934     4846      -88     
- Misses        904      993      +89     
Impacted Files Coverage Δ
...re/src/main/scala/dev/guardrail/core/Mappish.scala 75.00% <0.00%> (-6.82%) ⬇️
...a/dev/guardrail/generators/ProtocolGenerator.scala 89.70% <100.00%> (-8.98%) ⬇️
...ail/generators/java/jackson/JacksonGenerator.scala 95.97% <100.00%> (+0.01%) ⬆️
...enerators/scala/circe/CirceProtocolGenerator.scala 92.50% <100.00%> (-0.50%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blast-hardcheese blast-hardcheese merged commit 6760c9b into guardrail-dev:master May 14, 2023
@blast-hardcheese blast-hardcheese deleted the chore/preparing-for-1591 branch May 14, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant