Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hygiene #1829

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Hygiene #1829

merged 5 commits into from
Oct 19, 2023

Conversation

blast-hardcheese
Copy link
Member

  • Addressing insufficient implicit typing
  • Scala 2.13 deprecations
  • Scala 2.11 TODO

The reason for reflectiveCalls is due to reflecting access to the
`unapply` method.
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (30d4bde) 82.41% compared to head (f1e8208) 82.41%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1829   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          93       93           
  Lines        7326     7326           
  Branches      869      825   -44     
=======================================
  Hits         6038     6038           
  Misses       1288     1288           
Files Coverage Δ
...ev/guardrail/generators/scala/ScalaGenerator.scala 90.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blast-hardcheese blast-hardcheese merged commit 0c9188b into guardrail-dev:master Oct 19, 2023
42 checks passed
@blast-hardcheese blast-hardcheese deleted the hygiene branch October 19, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant