Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Installing validators concepts page with incode examples #1010

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

AlejandroEsquivel
Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel commented Aug 13, 2024

Added:

  • Added Validators concept page with examples of how to install: cli, in-code patterns

@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review August 13, 2024 23:10
@dtam
Copy link
Contributor

dtam commented Aug 13, 2024

keeping this out of the validators page for brevity? any other reason to not combine?

@AlejandroEsquivel
Copy link
Contributor Author

keeping this out of the validators page for brevity? any other reason to not combine?

yeah for brevity, but i suppose they could use the sidebar on the right to identify the install section so could be combined

@AlejandroEsquivel AlejandroEsquivel marked this pull request as draft August 13, 2024 23:23
@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review August 13, 2024 23:35
@AlejandroEsquivel AlejandroEsquivel requested a review from a team August 13, 2024 23:35
@AlejandroEsquivel
Copy link
Contributor Author

keeping this out of the validators page for brevity? any other reason to not combine?

Ended up combining 👍🏼

docs/concepts/validators.md Outdated Show resolved Hide resolved
Co-authored-by: dtam <david.cheung.tam@gmail.com>
@dtam dtam merged commit a8a70cf into main Aug 15, 2024
12 checks passed
@dtam dtam deleted the ae/docs-in-code-installs branch August 15, 2024 16:53
@zsimjee zsimjee added this to the v0.5.5 Release tracker milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants