Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated UX of guardrails configure #864

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Updated UX of guardrails configure #864

merged 6 commits into from
Jul 1, 2024

Conversation

AlejandroEsquivel
Copy link
Contributor

Updated

  • Updated guardrails configure to contain URL for getting API keys
  • Added message indicating that if no API key is provided it will keep the existing key

@AlejandroEsquivel AlejandroEsquivel marked this pull request as draft June 26, 2024 19:40
@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review June 26, 2024 21:17
@AlejandroEsquivel AlejandroEsquivel requested a review from a team June 26, 2024 21:17
JosephCatrambone
JosephCatrambone approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@JosephCatrambone JosephCatrambone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledging the soon-to-be tokens -> keys redirect, this looks good to me. Tested on my machine and it seems to work.

@CalebCourier
Copy link
Collaborator

@AlejandroEsquivel I'm repointing this to 0.5.0-dev so we can get it merged in and tested accordingly.

@CalebCourier CalebCourier changed the base branch from main to 0.5.0-dev July 1, 2024 15:04
@CalebCourier CalebCourier merged commit d4232d4 into 0.5.0-dev Jul 1, 2024
12 checks passed
@CalebCourier CalebCourier deleted the feat/cli-configure-ux-enhancements branch July 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephCatrambone JosephCatrambone JosephCatrambone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlejandroEsquivel @CalebCourier @JosephCatrambone