Otel Fixes #924
Merged
Otel Fixes #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlejandroEsquivel This still needs to be tested against the programmatic instrumentation on the api. I only tested with manual instrumentation client side. |
|
@CalebCourier verified this does indeed fix Guardrails API telemetry issues with no further changes needed (just need documentation to ensure proper env var configuration set) |
|
Cleaned up and summarized findings in [Notion - Telemetry Debug] |
AlejandroEsquivel
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues when attempting to use multiple sinks at once.
We still need to better manage user specified tracer providers and otel related contexts (see #869), but this at leasts enforces the expected behaviour as shown here: https://github.com/guardrails-ai/guardrails-test/tree/otel-debug/telemetry